[Asterisk-code-review] Remove constant conditionals (dead-code). (asterisk[master])

Corey Farrell asteriskteam at digium.com
Tue Dec 19 08:31:37 CST 2017


Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/7629 )

Change subject: Remove constant conditionals (dead-code).
......................................................................


Patch Set 2: Code-Review-1

George Joseph has asked that I use `#if 0` in res_config_ldap instead of deleting the code.  As such I'll be leaving `int pos = 0;` and `&valptr[pos]` as they were.

Updated review will follow shortly.


-- 
To view, visit https://gerrit.asterisk.org/7629
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I62e2aac353d739fb3c983cf768933120f5fba059
Gerrit-Change-Number: 7629
Gerrit-PatchSet: 2
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Tue, 19 Dec 2017 14:31:37 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171219/b9e97735/attachment-0001.html>


More information about the asterisk-code-review mailing list