[Asterisk-code-review] Remove constant conditionals (dead-code). (asterisk[master])

Corey Farrell asteriskteam at digium.com
Mon Dec 18 17:06:36 CST 2017


Hello Richard Mudgett, Jenkins2, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/7629

to look at the new patch set (#2).

Change subject: Remove constant conditionals (dead-code).
......................................................................

Remove constant conditionals (dead-code).

Some variables are set and never changed, making them constant.  This
means that code in the 'false' block of the conditional is unreachable.

In the case of chan_skinny I used preprocessor directive `#if 0` as I'm
unsure if the video handling could be enabled in the future.

Change-Id: I62e2aac353d739fb3c983cf768933120f5fba059
---
M channels/chan_skinny.c
M main/manager_system.c
M main/stdtime/localtime.c
M main/xmldoc.c
M res/res_config_ldap.c
5 files changed, 18 insertions(+), 78 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/29/7629/2
-- 
To view, visit https://gerrit.asterisk.org/7629
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I62e2aac353d739fb3c983cf768933120f5fba059
Gerrit-Change-Number: 7629
Gerrit-PatchSet: 2
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171218/5cbb8398/attachment.html>


More information about the asterisk-code-review mailing list