[Asterisk-code-review] CLI: Fix 'core set debug channel' completion bug. (asterisk[15])

Joshua Colp asteriskteam at digium.com
Mon Dec 18 16:07:28 CST 2017


Joshua Colp has submitted this change and it was merged. ( https://gerrit.asterisk.org/7626 )

Change subject: CLI: Fix 'core set debug channel' completion bug.
......................................................................

CLI: Fix 'core set debug channel' completion bug.

The completion generator is missing a return so typing "core set debug
all off <tab>" causes the command to actually execute.

Change-Id: Ibf6462088a74eee66967732b50445783ebefc20b
---
M main/cli.c
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Richard Mudgett: Looks good to me, but someone else must approve
  George Joseph: Looks good to me, approved
  Joshua Colp: Approved for Submit



diff --git a/main/cli.c b/main/cli.c
index 0f023b2..654134e 100644
--- a/main/cli.c
+++ b/main/cli.c
@@ -1418,6 +1418,8 @@
 		} else if (a->pos == 5) {
 			return ast_cli_complete(a->word, completions_off, a->n);
 		}
+
+		return NULL;
 	}
 
 	if (cmd == (CLI_HANDLER + 1000)) {

-- 
To view, visit https://gerrit.asterisk.org/7626
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibf6462088a74eee66967732b50445783ebefc20b
Gerrit-Change-Number: 7626
Gerrit-PatchSet: 1
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171218/d48e43c3/attachment.html>


More information about the asterisk-code-review mailing list