[Asterisk-code-review] features: Stop music on hold in Bridge AMI action (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/7616 )

Change subject: features: Stop music on hold in Bridge AMI action
......................................................................


Patch Set 2: Code-Review-1

(3 comments)

https://gerrit.asterisk.org/#/c/7616/2/main/features.c
File main/features.c:

https://gerrit.asterisk.org/#/c/7616/2/main/features.c@791
PS2, Line 791: 	if (ast_test_flag(ast_channel_flags(chana), AST_FLAG_MOH)) {
             : 		ast_moh_stop(chana);
             : 	}
Undo this and see the third comment.


https://gerrit.asterisk.org/#/c/7616/2/main/features.c@810
PS2, Line 810: 	if (ast_test_flag(ast_channel_flags(chanb), AST_FLAG_MOH)) {
             : 		ast_moh_stop(chanb);
             : 	}
Undo this and see the third comment.


https://gerrit.asterisk.org/#/c/7616/2/main/features.c@821
PS2, Line 821: 	if (ast_bridge_add_channel(bridge, chana, NULL, playtone & PLAYTONE_CHANNEL1, xfer_cfg_a ? xfer_cfg_a->xfersound : NULL)) {
The main/bridge.c:ast_bridge_add_channel() function should unconditionally call ast_moh_stop() just like the main/features.c:do_bridge_masquerade() function did in v11.  This will not only fix the MOH problem with the AMI Bridge action but also fix the same problem with the Bridge dialplan application and make use the right MOH class for the AMI Park action when the channel gets parked.



-- 
To view, visit https://gerrit.asterisk.org/7616
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I4b129c5a20c15e63968842460ac5a1a85903cf9f
Gerrit-Change-Number: 7616
Gerrit-PatchSet: 2
Gerrit-Owner: Ivan Poddubny <ivan.poddubny at gmail.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Mon, 18 Dec 2017 20:39:01 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171218/76594fa0/attachment.html>