[Asterisk-code-review] CLI: Simplify composite completion generators. (asterisk[master])

Corey Farrell asteriskteam at digium.com
Fri Dec 15 08:45:07 CST 2017


Hello Jenkins2, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/7558

to look at the new patch set (#2).

Change subject: CLI: Simplify composite completion generators.
......................................................................

CLI: Simplify composite completion generators.

Add support for ast_cli_complete and ast_complete_channels to use
ast_cli_completion_add instead of returning values.  Both functions
switch modes when they are given -1 instead of a->n.

Additionally fixes issue where "core set debug channel all off <tab>" would
actually execute "core set debug channel all off " as we were missing a
return NULL when a->pos > 5.

Change-Id: Iebef61424689569338d0916ff2e37df944ac76fa
---
M channels/chan_iax2.c
M channels/chan_sip.c
M channels/chan_skinny.c
M include/asterisk/cli.h
M main/bridge.c
M main/cli.c
6 files changed, 49 insertions(+), 42 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/58/7558/2
-- 
To view, visit https://gerrit.asterisk.org/7558
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iebef61424689569338d0916ff2e37df944ac76fa
Gerrit-Change-Number: 7558
Gerrit-PatchSet: 2
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171215/f44f2303/attachment.html>


More information about the asterisk-code-review mailing list