[Asterisk-code-review] aco: Create ways to minimize use of regex. (asterisk[15])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/7564 )

Change subject: aco: Create ways to minimize use of regex.
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/7564/1/main/config_options.c
File main/config_options.c:

https://gerrit.asterisk.org/#/c/7564/1/main/config_options.c@414
PS1, Line 414: !regexec(match->internal->regex, category, 0, NULL, 0) == !match->category_match
This is a little confusing because it depends on knowing that regexec returns a 0 for a match and that ACO_BLACKLIST is a 0 and ACO_WHITELIST is a 1.  It's a nice clean implementation but I think at least a comment is needed to explain.



-- 
To view, visit https://gerrit.asterisk.org/7564
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: comment
Gerrit-Change-Id: I66a920dcd8e2b0301f73f968016440a985e72821
Gerrit-Change-Number: 7564
Gerrit-PatchSet: 1
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Fri, 15 Dec 2017 14:34:39 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171215/5a747fac/attachment.html>