[Asterisk-code-review] loader: Rework of load dynamic module. (asterisk[master])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/7519 )

Change subject: loader: Rework of load_dynamic_module.
......................................................................


Patch Set 2:

> Richard:
 > You mentioned this patch should be cherry-picked.  My one concern
 > with this patch is the use of RTLD_NOW for global modules.  The
 > current system with RTLD_LAZY tolerates some symbol reference
 > issues that would fail under RTLD_NOW.  So maybe 13/15 could get
 > this patch except continue using RTLD_LAZY for global symbol
 > modules?  If a 3rd party has 2 modules that use each other's global
 > symbols it should not stop working on release of 13.19.0.

Continuing to use RTLD_LAZY would work and you get all the other benefits
of this patch.  Faster load times, consistent error checking, and elimination
of load_dynamic_module() requiring that the loaded mod struct is put on
the end of module_list.


-- 
To view, visit https://gerrit.asterisk.org/7519
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2c9903cfddcc01aed3e01c1e7fe4a3fb9af0f8b
Gerrit-Change-Number: 7519
Gerrit-PatchSet: 2
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Fri, 15 Dec 2017 14:15:59 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171215/7b1db7d3/attachment.html>