[Asterisk-code-review] loader: Minor fix to module registration. (asterisk[master])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/7518 )

Change subject: loader: Minor fix to module registration.
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.asterisk.org/#/c/7518/1/main/loader.c
File main/loader.c:

https://gerrit.asterisk.org/#/c/7518/1/main/loader.c@198
PS1, Line 198: 	mod = resource_being_loaded;
> Why not set resource_being_loaded to NULL here since we are taking the reso
Done now, I just hadn't thought of it.


https://gerrit.asterisk.org/#/c/7518/1/main/loader.c@574
PS1, Line 574: 		return NULL;
> Isn't mod leaked here?  The module didn't register itself so it shouldn't b
Yes, I misread ast_module_unregister, didn't click in that mod couldn't be freed if it's not in the list.



-- 
To view, visit https://gerrit.asterisk.org/7518
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I40f07a315e55b92df4fc7faf525ed6d4f396e7d2
Gerrit-Change-Number: 7518
Gerrit-PatchSet: 1
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Thu, 14 Dec 2017 23:54:45 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171214/15e429d2/attachment.html>