[Asterisk-code-review] aco: Minimize use of regex. (asterisk[master])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/7530 )

Change subject: aco: Minimize use of regex.
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.asterisk.org/#/c/7530/3//COMMIT_MSG
Commit Message:

https://gerrit.asterisk.org/#/c/7530/3//COMMIT_MSG@11
PS3, Line 11: * ast_sorcery_object_fields_register is implemented with regex, all
            :   callers use simple prefix based regex.  I haven't decided the best
            :   way to fix this in both 13/15 and master.
> You've got code reviews up for 13 and 15 now so is this comment still accur
The reviews do not include changes to ast_sorcery_object_fields_register.  That function has an argument 'const char *regex' so the only way to fix is create a new function which operates on prefixes or break the API.



-- 
To view, visit https://gerrit.asterisk.org/7530
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5ed478218d8a661ace4d2eaaea98b59a897974b
Gerrit-Change-Number: 7530
Gerrit-PatchSet: 3
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Thu, 14 Dec 2017 17:36:46 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171214/a07dfcfb/attachment.html>