[Asterisk-code-review] menuselect: Tweak check for recently run configure. (asterisk[13])

Joshua Colp asteriskteam at digium.com
Thu Dec 14 07:14:47 CST 2017


Joshua Colp has submitted this change and it was merged. ( https://gerrit.asterisk.org/7533 )

Change subject: menuselect: Tweak check for recently run configure.
......................................................................

menuselect: Tweak check for recently run configure.

Recently menuselect has randomly produced an error stating that
configure was just run and make had to be restarted.  I believe this is
due to an incorrect menuselect/Makefile rule.  The original rule
produced an error if makeopts or autoconfig.h were older than
makeopts.in or autoconfig.h.in.  I believe this can create an issue if
makeopts is older than autoconfig.h.in or if autoconfig.h is older than
makeopts.in.  The new rules compare files independently.

Change-Id: Ibca155035fa1392c95e33cbf25f257902abba17b
---
M menuselect/Makefile
1 file changed, 4 insertions(+), 1 deletion(-)

Approvals:
  Matthew Fredrickson: Looks good to me, but someone else must approve
  Joshua Colp: Looks good to me, approved; Approved for Submit



diff --git a/menuselect/Makefile b/menuselect/Makefile
index 96c574e..c6a6fac 100644
--- a/menuselect/Makefile
+++ b/menuselect/Makefile
@@ -64,7 +64,10 @@
 
 $(OBJS) $(C_OBJS) $(N_OBJS) $(G_OBJS) $(M_OBJS): autoconfig.h menuselect.h
 
-makeopts autoconfig.h: autoconfig.h.in makeopts.in
+makeopts: makeopts.in
+autoconfig.h: autoconfig.h.in
+
+makeopts autoconfig.h:
 	@./configure $(CONFIGURE_SILENT)
 	@echo "****"
 	@echo "**** The configure script was just executed, so 'make' needs to be"

-- 
To view, visit https://gerrit.asterisk.org/7533
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibca155035fa1392c95e33cbf25f257902abba17b
Gerrit-Change-Number: 7533
Gerrit-PatchSet: 1
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171214/2d647d58/attachment-0001.html>


More information about the asterisk-code-review mailing list