[Asterisk-code-review] secure calling: Add nominal call tests (testsuite[master])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/7474 )

Change subject: secure_calling:  Add nominal call tests
......................................................................


Patch Set 2:

(4 comments)

https://gerrit.asterisk.org/#/c/7474/2/tests/channels/pjsip/secure_calling/calls/nominal/all_ciphers_verify_certs/test-config.yaml
File tests/channels/pjsip/secure_calling/calls/nominal/all_ciphers_verify_certs/test-config.yaml:

https://gerrit.asterisk.org/#/c/7474/2/tests/channels/pjsip/secure_calling/calls/nominal/all_ciphers_verify_certs/test-config.yaml@85
PS2, Line 85:     minversion: '12.0.0'
> Is this minversion true?

yep


https://gerrit.asterisk.org/#/c/7474/2/tests/channels/pjsip/secure_calling/calls/nominal/limited_ciphers_verify_certs/test-config.yaml
File tests/channels/pjsip/secure_calling/calls/nominal/limited_ciphers_verify_certs/test-config.yaml:

https://gerrit.asterisk.org/#/c/7474/2/tests/channels/pjsip/secure_calling/calls/nominal/limited_ciphers_verify_certs/test-config.yaml@87
PS2, Line 87:     minversion: '12.0.0'
> minversion correct?

The test should pass for 12.0.0


https://gerrit.asterisk.org/#/c/7474/2/tests/channels/pjsip/secure_calling/calls/nominal/two_CAs_no_verify_certs/test-config.yaml
File tests/channels/pjsip/secure_calling/calls/nominal/two_CAs_no_verify_certs/test-config.yaml:

https://gerrit.asterisk.org/#/c/7474/2/tests/channels/pjsip/secure_calling/calls/nominal/two_CAs_no_verify_certs/test-config.yaml@89
PS2, Line 89:     minversion: '12.0.0'
> Minversion question again?
it's ok


https://gerrit.asterisk.org/#/c/7474/2/tests/channels/pjsip/secure_calling/calls/nominal/two_CAs_verify_certs/test-config.yaml
File tests/channels/pjsip/secure_calling/calls/nominal/two_CAs_verify_certs/test-config.yaml:

https://gerrit.asterisk.org/#/c/7474/2/tests/channels/pjsip/secure_calling/calls/nominal/two_CAs_verify_certs/test-config.yaml@91
PS2, Line 91:     minversion: '12.0.0'
> minversion?

same



-- 
To view, visit https://gerrit.asterisk.org/7474
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id25b4811ed075223ed77635a25e04e2d3abb4e55
Gerrit-Change-Number: 7474
Gerrit-PatchSet: 2
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Wed, 13 Dec 2017 18:00:15 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171213/e1b8bc2e/attachment-0001.html>