[Asterisk-code-review] AST-2017-012: Place single RTCP report block at beginning of... (asterisk[15])

Joshua Colp asteriskteam at digium.com
Wed Dec 13 07:35:59 CST 2017


Hello Jenkins2, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/7551

to look at the new patch set (#2).

Change subject: AST-2017-012: Place single RTCP report block at beginning of report.
......................................................................

AST-2017-012: Place single RTCP report block at beginning of report.

When the RTCP code was transitioned over to Stasis a code change
was made to keep track of how many reports are present. This count
controlled where report blocks were placed in the RTCP report.

If a compound RTCP packet was received this logic would incorrectly
place a report block in the wrong location resulting in a write
to an invalid location.

This change removes this counting logic and always places the report
block at the first position. If in the future multiple reports are
supported the logic can be extended but for now keeping a count
serves no purpose.

ASTERISK-27382
ASTERISK-27429

Change-Id: Iad6c8a9985c4b608ef493e19c421211615485116
---
M res/res_rtp_asterisk.c
1 file changed, 3 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/51/7551/2
-- 
To view, visit https://gerrit.asterisk.org/7551
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iad6c8a9985c4b608ef493e19c421211615485116
Gerrit-Change-Number: 7551
Gerrit-PatchSet: 2
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Jenkins2
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171213/3e6b43d1/attachment.html>


More information about the asterisk-code-review mailing list