[Asterisk-code-review] secure calling: Add off-nominal call tests (testsuite[master])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/7528 )

Change subject: secure_calling:  Add off-nominal call tests
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

You've got a wee bit of redness in some test-config.yaml

As well for the dtls cases - it's the DTLS negotiation that fails, not the SDP negotiation.

https://gerrit.asterisk.org/#/c/7528/1/tests/channels/pjsip/secure_calling/calls/off-nominal/sips_verify_failure/configs/ast2/pjsip.conf
File tests/channels/pjsip/secure_calling/calls/off-nominal/sips_verify_failure/configs/ast2/pjsip.conf:

https://gerrit.asterisk.org/#/c/7528/1/tests/channels/pjsip/secure_calling/calls/off-nominal/sips_verify_failure/configs/ast2/pjsip.conf@7
PS1, Line 7: cipher = cipher = AES128-CCM,AES128-CCM8,AES128-GCM-SHA256,AES128-SHA256,AES256-SHA256
This seems wrong.



-- 
To view, visit https://gerrit.asterisk.org/7528
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I898602f411b68a60fab1cc99fffec1714d5999d9
Gerrit-Change-Number: 7528
Gerrit-PatchSet: 1
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Wed, 13 Dec 2017 11:21:45 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171213/051de389/attachment.html>