[Asterisk-code-review] chan sip: 3PCC patch for AMI "SIPnotify" (asterisk[master])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/7461 )

Change subject: chan_sip: 3PCC patch for AMI "SIPnotify"
......................................................................


Patch Set 5:

> As a user I would prefer an API allowing to specify a channel name
 > instead of Call-ID that is much harder to get. The AMI action
 > already has a Channel parameter that has a misleading name because
 > it's not really a channel but a peer name. I think there is an
 > opportunity to add a new feature (in-dialog notifies) and make the
 > existing API clearer (allowing to use channels in Channel header)
 > at the same time. What do you think?

I'm -1 on this idea.  In hindsight it would have been nice if the parameter were always 'Peer' instead of 'Channel' but it's already done.  What you've done so far is low impact and non-breaking.  I don't think this is worth making a breaking change, especially given the support status of chan_sip.


-- 
To view, visit https://gerrit.asterisk.org/7461
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5797ded4752acd966db6b13971284db684cc5ab4
Gerrit-Change-Number: 7461
Gerrit-PatchSet: 5
Gerrit-Owner: Yasuhiko Kamata <yasuhiko.kamata at nxtg.co.jp>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Ivan Poddubny <ivan.poddubny at gmail.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Yasuhiko Kamata <yasuhiko.kamata at nxtg.co.jp>
Gerrit-Comment-Date: Tue, 12 Dec 2017 22:51:58 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171212/5b7f097c/attachment-0001.html>