[Asterisk-code-review] aco: Minimize use of regex. (asterisk[master])

Corey Farrell asteriskteam at digium.com
Tue Dec 12 14:55:57 CST 2017


Hello Jenkins2, George Joseph, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/7530

to look at the new patch set (#2).

Change subject: aco: Minimize use of regex.
......................................................................

aco: Minimize use of regex.

Remove nearly all use of regex from ACO users.  Still remaining:
* app_confbridge has a legitamate use of option name regex.
* ast_sorcery_object_fields_register is implemented with regex, all
  callers use simple prefix based regex.  I haven't decided the best
  way to fix this in both 13/15 and master.

Change-Id: Ib5ed478218d8a661ace4d2eaaea98b59a897974b
---
M apps/app_agent_pool.c
M apps/app_skel.c
M apps/confbridge/conf_config_parser.c
M channels/chan_motif.c
M main/cdr.c
M main/cel.c
M main/features_config.c
M main/named_acl.c
M main/stasis.c
M main/udptl.c
M res/ari/config.c
M res/res_hep.c
M res/res_parking.c
M res/res_pjsip_notify.c
M res/res_resolver_unbound.c
M res/res_statsd.c
M res/res_xmpp.c
M tests/test_config.c
18 files changed, 126 insertions(+), 75 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/30/7530/2
-- 
To view, visit https://gerrit.asterisk.org/7530
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5ed478218d8a661ace4d2eaaea98b59a897974b
Gerrit-Change-Number: 7530
Gerrit-PatchSet: 2
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171212/efee86d8/attachment.html>


More information about the asterisk-code-review mailing list