[Asterisk-code-review] chan pjsip/res pjsip: Add CHANNEL(pjsip,request uri) (asterisk[13])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/7510 )

Change subject: chan_pjsip/res_pjsip: Add CHANNEL(pjsip,request_uri)
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/7510/1/channels/pjsip/dialplan_functions.c
File channels/pjsip/dialplan_functions.c:

https://gerrit.asterisk.org/#/c/7510/1/channels/pjsip/dialplan_functions.c@718
PS1, Line 718: 			pjsip_uri_print(PJSIP_URI_IN_REQ_URI, channel->session->request_uri, buf, buflen);
The return value should be checked here. If uri_print returns -1 then buf is left without a null terminator.



-- 
To view, visit https://gerrit.asterisk.org/7510
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I512e60d1f162395c946451becb37af3333337b33
Gerrit-Change-Number: 7510
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Tue, 12 Dec 2017 00:12:44 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171211/afec2dde/attachment.html>