[Asterisk-code-review] pjsip options: wrongly applied "UNKNOWN" status (asterisk[master])

Kevin Harwell asteriskteam at digium.com
Mon Dec 11 15:27:24 CST 2017


Hello Jenkins2, Joshua Colp, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/7481

to look at the new patch set (#2).

Change subject: pjsip_options: wrongly applied "UNKNOWN" status
......................................................................

pjsip_options: wrongly applied "UNKNOWN" status

A couple of places were setting the status to "UNKNOWN" when qualifies were
being disabled. Instead this should be set to the "CREATED" status that
represents when a contact is given (uri available), but the qualify frequency
is set to zero so we don't know the status.

This patch updates the relevant places with "CREATED". It also updates the
"CREATED" status description (value shown in CLI/AMI/ARI output) to a value
of "NonQualified"/"NonQual" as this description is hopefully less confusing.

ASTERISK-27467

Change-Id: Id67509d25df92a72eb3683720ad2a95a27b50c89
---
M CHANGES
M UPGRADE.txt
M include/asterisk/res_pjsip.h
M main/stasis_endpoints.c
M res/res_pjsip.c
M res/res_pjsip/pjsip_options.c
M rest-api/api-docs/events.json
7 files changed, 37 insertions(+), 24 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/81/7481/2
-- 
To view, visit https://gerrit.asterisk.org/7481
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id67509d25df92a72eb3683720ad2a95a27b50c89
Gerrit-Change-Number: 7481
Gerrit-PatchSet: 2
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171211/6db6a966/attachment.html>


More information about the asterisk-code-review mailing list