[Asterisk-code-review] chan sip: 3PCC patch for AMI "SIPnotify" (asterisk[master])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/7461 )

Change subject: chan_sip: 3PCC patch for AMI "SIPnotify"
......................................................................


Patch Set 4: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/7461/4/channels/chan_sip.c
File channels/chan_sip.c:

https://gerrit.asterisk.org/#/c/7461/4/channels/chan_sip.c@598
PS4, Line 598: 				i.e. will be transmitted in a series of one SIP flows (from INVITE to BYE).</para>
This confuses me a bit (and I've ready your code change).  When "Call-ID" is specified I know we find an existing dialog.  Does the SIPnotify cause a "BYE" to be sent once the notification is sent?

Maybe clearer:
<para>When specified, SIP notity will be sent as a part of an existing dialog.</para>



-- 
To view, visit https://gerrit.asterisk.org/7461
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5797ded4752acd966db6b13971284db684cc5ab4
Gerrit-Change-Number: 7461
Gerrit-PatchSet: 4
Gerrit-Owner: Yasuhiko Kamata <yasuhiko.kamata at nxtg.co.jp>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Yasuhiko Kamata <yasuhiko.kamata at nxtg.co.jp>
Gerrit-Comment-Date: Mon, 11 Dec 2017 18:05:31 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171211/c64a3c39/attachment.html>