[Asterisk-code-review] pjsip options: contacts sometimes not being updated on reload (asterisk[13])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/7486 )

Change subject: pjsip_options: contacts sometimes not being updated on reload
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/7486/1/res/res_pjsip/pjsip_options.c
File res/res_pjsip/pjsip_options.c:

https://gerrit.asterisk.org/#/c/7486/1/res/res_pjsip/pjsip_options.c@1193
PS1, Line 1193: 	/*
              : 	 * It's possible that the AOR had some of it's fields updated prior to a
              : 	 * reload. For instance qualifying could have been turned on or off by
              : 	 * setting the qualify_frequency. Due to this we have to iterate through
              : 	 * all contacts (static and dynamic), and not just ones where the frequency
              : 	 * is greater than zero, updating any contact fields with the AOR's values.
              : 	 */
> Instead of retrieving everything would it be possible to keep the specific 
You have to iterate over all items in order to update any field that might have changed. qualify_frequency is just an example of one field. Also the status itself potentially needs updating if qualify_frequency was set to 0.

Unfortunately, on reload, since there is no way to know which AOR/contact might have changed we have to go through all of them.



-- 
To view, visit https://gerrit.asterisk.org/7486
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a920170f89c683af9505d4723a44fc6841decdb
Gerrit-Change-Number: 7486
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Mon, 11 Dec 2017 15:36:16 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171211/868470f8/attachment.html>