[Asterisk-code-review] pjsip options: wrongly applied "UNKNOWN" status (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/7478 )

Change subject: pjsip_options: wrongly applied "UNKNOWN" status
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

I think "UNKNOWN" as a state makes more sense for these, at least from a conceptual and end user perspective. It's come up on the community site that people get confused over what "CREATED" actually means.

https://gerrit.asterisk.org/#/c/7478/1//COMMIT_MSG
Commit Message:

https://gerrit.asterisk.org/#/c/7478/1//COMMIT_MSG@10
PS1, Line 10: being disabeled. Instead this should be set to the "CREATED" status that
disabled.



-- 
To view, visit https://gerrit.asterisk.org/7478
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Id67509d25df92a72eb3683720ad2a95a27b50c89
Gerrit-Change-Number: 7478
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Mon, 11 Dec 2017 12:42:05 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171211/ef7bf8bb/attachment.html>