[Asterisk-code-review] astdb: Improve prefix searches in astdb (asterisk[master])

Corey Farrell asteriskteam at digium.com
Fri Dec 8 13:28:39 CST 2017


Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/7477 )

Change subject: astdb: Improve prefix searches in astdb
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.asterisk.org/#/c/7477/2/res/res_sorcery_astdb.c
File res/res_sorcery_astdb.c:

https://gerrit.asterisk.org/#/c/7477/2/res/res_sorcery_astdb.c@302
PS2, Line 302: 	if (!(entries = ast_db_gettree(family, tree))
Should something different be done here when regex[0] == '^'?  Or if ast_db_gettree_by_prefix will do the right thing with tree == "" maybe we just always call that function?



-- 
To view, visit https://gerrit.asterisk.org/7477
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d37f9ba2aea139dabf2ca72d31fbe34bd9b2fa1
Gerrit-Change-Number: 7477
Gerrit-PatchSet: 2
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Fri, 08 Dec 2017 19:28:39 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171208/0d282343/attachment.html>


More information about the asterisk-code-review mailing list