[Asterisk-code-review] utils: Add convenience function for setting fd flags (asterisk[15])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/7472 )

Change subject: utils: Add convenience function for setting fd flags
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/7472/3/include/asterisk/utils.h
File include/asterisk/utils.h:

https://gerrit.asterisk.org/#/c/7472/3/include/asterisk/utils.h@1176
PS3, Line 1176: int _ast_fd_set_flags(int fd, int flags, int set, const char *file, int lineno);
How about an enum for set/clear to make things a little clearer, especially during debugging since the enum symbol will show in the backtrace instead of just 0 or 1.



-- 
To view, visit https://gerrit.asterisk.org/7472
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: comment
Gerrit-Change-Id: I8b81901e1b1bd537ca632567cdb408931c6eded7
Gerrit-Change-Number: 7472
Gerrit-PatchSet: 3
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Comment-Date: Thu, 07 Dec 2017 19:30:54 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171207/abadc254/attachment-0001.html>