[Asterisk-code-review] bridge basic.c: Update transfer diagnostic messages addendum. (asterisk[master])

Joshua Colp asteriskteam at digium.com
Thu Dec 7 06:40:58 CST 2017


Joshua Colp has submitted this change and it was merged. ( https://gerrit.asterisk.org/7452 )

Change subject: bridge_basic.c: Update transfer diagnostic messages addendum.
......................................................................

bridge_basic.c: Update transfer diagnostic messages addendum.

* Added start DTMF transfer verbose messages.
* Made associated transfer messages use a similar message format.
* Adjusted message verbose level as requested by initial reporter.

ASTERISK-27449

Change-Id: I2045714586414b3c5ef1f3cc56c1c4af4b31f551
---
M main/bridge_basic.c
1 file changed, 9 insertions(+), 3 deletions(-)

Approvals:
  George Joseph: Looks good to me, but someone else must approve
  Matthew Fredrickson: Looks good to me, but someone else must approve
  Joshua Colp: Looks good to me, approved; Approved for Submit



diff --git a/main/bridge_basic.c b/main/bridge_basic.c
index 6b393f4..68138bd 100644
--- a/main/bridge_basic.c
+++ b/main/bridge_basic.c
@@ -3215,9 +3215,9 @@
 		} else if (!res) {
 			/* 0 for invalid extension dialed. */
 			if (ast_strlen_zero(exten)) {
-				ast_verb(4, "%s dialed no digits.\n", ast_channel_name(chan));
+				ast_verb(3, "Channel %s: Dialed no digits.\n", ast_channel_name(chan));
 			} else {
-				ast_verb(4, "%s dialed '%s@%s' does not exist.\n",
+				ast_verb(3, "Channel %s: Dialed '%s@%s' does not exist.\n",
 					ast_channel_name(chan), exten, context);
 			}
 			if (attempts < max_attempts) {
@@ -3303,6 +3303,9 @@
 
 	/* Inhibit the bridge before we do anything else. */
 	bridge = ast_bridge_channel_merge_inhibit(bridge_channel, +1);
+
+	ast_verb(3, "Channel %s: Started DTMF attended transfer.\n",
+		ast_channel_name(bridge_channel->chan));
 
 	if (strcmp(bridge->v_table->name, "basic")) {
 		ast_log(LOG_ERROR, "Channel %s: Attended transfer attempted on unsupported bridge type '%s'.\n",
@@ -3473,6 +3476,9 @@
 	const char *xfer_context;
 	char *goto_on_blindxfr;
 
+	ast_verb(3, "Channel %s: Started DTMF blind transfer.\n",
+		ast_channel_name(bridge_channel->chan));
+
 	ast_bridge_channel_write_hold(bridge_channel, NULL);
 
 	ast_channel_lock(bridge_channel->chan);
@@ -3496,7 +3502,7 @@
 		const char *chan_exten;
 		int chan_priority;
 
-		ast_debug(1, "After transfer, transferrer %s goes to %s\n",
+		ast_debug(1, "Channel %s: After transfer, transferrer goes to %s\n",
 			ast_channel_name(bridge_channel->chan), goto_on_blindxfr);
 
 		ast_channel_lock(bridge_channel->chan);

-- 
To view, visit https://gerrit.asterisk.org/7452
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I2045714586414b3c5ef1f3cc56c1c4af4b31f551
Gerrit-Change-Number: 7452
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171207/440733d0/attachment.html>


More information about the asterisk-code-review mailing list