[Asterisk-code-review] chan sip: Peers with distinct source ports don't match, rega... (asterisk[13])

[Alexander Traud]

Alexander Traud has posted comments on this change. ( https://gerrit.asterisk.org/7430 )

Change subject: chan_sip: Peers with distinct source ports don't match, regardless of transport.
......................................................................


Patch Set 1:

Well, there is an issue in that function (at least one, I guess there are two). This affects not only allowguest, as mentioned by Stephane. He found a workaround, but that was a workaround. It should work correctly on default.

If I knew all scenarios, I could do some tests. Otherwise I change the code to allow insecure=port even on TCP/TLS. No use from my point of view. But not any harm either because it is the current situation.


-- 
To view, visit https://gerrit.asterisk.org/7430
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Id190428bf1d931f2dbfd4b293f53ff8f20d98efa
Gerrit-Change-Number: 7430
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Wed, 06 Dec 2017 14:23:58 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171206/62c07bfc/attachment.html>