[Asterisk-code-review] res rtp asterisk.c: Increase strictrtp learning timeout time. (asterisk[13])

Kevin Harwell asteriskteam at digium.com
Tue Dec 5 17:18:12 CST 2017


Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/7435 )

Change subject: res_rtp_asterisk.c: Increase strictrtp learning timeout time.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/7435/1/res/res_rtp_asterisk.c
File res/res_rtp_asterisk.c:

https://gerrit.asterisk.org/#/c/7435/1/res/res_rtp_asterisk.c@142
PS1, Line 142: /*!
             :  * \brief Strict RTP learning timeout time in milliseconds
             :  *
             :  * \note Set to 5 seconds to allow reinvite chains for direct media
             :  * to settle before media actually starts to arrive.  There may be a
             :  * reinvite collision involved on the other leg.
             :  */
             : #define STRICT_RTP_LEARN_TIMEOUT	5000
Should this be extended, or should those scenarios where more time is needed instead delay the start of the learning period?



-- 
To view, visit https://gerrit.asterisk.org/7435
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic5e711164cbb91b4d1c1e40c83697755640f138c
Gerrit-Change-Number: 7435
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Tue, 05 Dec 2017 23:18:12 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171205/8e5bedb3/attachment.html>


More information about the asterisk-code-review mailing list