[Asterisk-code-review] security-events: Fix SuccessfulAuth using password declaration. (asterisk[master])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/7445 )

Change subject: security-events: Fix SuccessfulAuth using_password declaration.
......................................................................


Patch Set 1:

> Did you look into why this was done at all?

Yes I did.  It went in with the 5982bdcb7c45d286ac7a84ab53fb4a74207d2467 change.  That change is adding new security events to chan_sip.  There is no explanation why struct ast_security_event_successful_auth.using_password was declared this way.  Its usage is patterned after AST_EVENT_IE_EVENT_VERSION.  However, struct ast_security_event_common.version is declared correctly as a uint32_t.  It is main/security_events.c:add_json_object() which has AST_EVENT_IE_EVENT_VERSION and AST_EVENT_IE_USING_PASSWORD executing the same switch case code to read the value out of the struct.


-- 
To view, visit https://gerrit.asterisk.org/7445
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia08bc797613a62f07e5473425f9ccd8d77c80935
Gerrit-Change-Number: 7445
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Tue, 05 Dec 2017 13:18:51 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171205/e1352882/attachment.html>