[Asterisk-code-review] Add new object for VoicemailUserEntry (asterisk[13])

sungtae kim asteriskteam at digium.com
Mon Dec 4 12:24:23 CST 2017


sungtae kim has uploaded this change for review. ( https://gerrit.asterisk.org/7440


Change subject: Add new object for VoicemailUserEntry
......................................................................

Add new object for VoicemailUserEntry

Currently, when the app_voicemail sending VoicemailUserEntry AMI event, there's
no OldMessageCount info for default.
To check the OldMessageCount info, it required IMAP_STORAGE define, but this is
not correct.
Added OldMessageCount item as a default.

ASTERISK-27456

Change-Id: I5c71521c2d1daf8b7b161e31c34d28cca6aea4c7
---
M apps/app_voicemail.c
1 file changed, 4 insertions(+), 7 deletions(-)



  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/40/7440/1

diff --git a/apps/app_voicemail.c b/apps/app_voicemail.c
index d0e1763..c080bfe 100644
--- a/apps/app_voicemail.c
+++ b/apps/app_voicemail.c
@@ -13347,11 +13347,8 @@
 	
 	AST_LIST_TRAVERSE(&users, vmu, list) {
 		char dirname[256];
-#ifdef IMAP_STORAGE
 		int new, old;
-
 		inboxcount(vmu->mailbox, &new, &old);
-#endif
 		
 		make_dir(dirname, sizeof(dirname), vmu->context, vmu->mailbox, "INBOX");
 		astman_append(s,
@@ -13383,8 +13380,8 @@
 			"MaxMessageCount: %d\r\n"
 			"MaxMessageLength: %d\r\n"
 			"NewMessageCount: %d\r\n"
-#ifdef IMAP_STORAGE
 			"OldMessageCount: %d\r\n"
+#ifdef IMAP_STORAGE
 			"IMAPUser: %s\r\n"
 			"IMAPServer: %s\r\n"
 			"IMAPPort: %s\r\n"
@@ -13417,14 +13414,14 @@
 			ast_test_flag(vmu, VM_OPERATOR) ? "Yes" : "No",
 			vmu->maxmsg,
 			vmu->maxsecs,
+			new,
+			old
 #ifdef IMAP_STORAGE
-			new, old,
+			,
 			vmu->imapuser,
 			vmu->imapserver,
 			vmu->imapport,
 			vmu->imapflags
-#else
-			count_messages(vmu, dirname)
 #endif
 			);
 		++num_users;

-- 
To view, visit https://gerrit.asterisk.org/7440
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5c71521c2d1daf8b7b161e31c34d28cca6aea4c7
Gerrit-Change-Number: 7440
Gerrit-PatchSet: 1
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171204/a3af517a/attachment.html>


More information about the asterisk-code-review mailing list