[Asterisk-code-review] chan sip: Peers with distinct source ports don't match, rega... (asterisk[13])

[Alexander Traud]

Alexander Traud has posted comments on this change. ( https://gerrit.asterisk.org/7430 )

Change subject: chan_sip: Peers with distinct source ports don't match, regardless of transport.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/7430/1/channels/chan_sip.c
File channels/chan_sip.c:

https://gerrit.asterisk.org/#/c/7430/1/channels/chan_sip.c@34132
PS1, Line 34132: 	if (((peer->transports & peer2->transports) &
> So should TCP/TLS not use INSECURE_PORT?
For TCP/TLS, the same connection must be re-used. I see no benefit in insecure=port for TCP/TLS.

However, David wrote something like "[For TCP,] the received packet's destination port will not match the one the peer table is built with." No idea what he was about. It is a pity that we cannot ask David anymore.

The code before this change looks like insecure=port is enabled for TCP/TLS always, regardless the settings in sip.conf. However, that might have been not a TCP/TLS issue in general but a specific issue at that time within Asterisk.

By the way, did you see my previous reply in master? When peer2 has, and peer1 does not have insecure=port, zero is returned. Instead, it should go through the port test and return zero only when the ports do not match. Or? With other words, only when UDP and both peers have insecure=port, then a match should be returned. Otherwise the ports should be checked.



-- 
To view, visit https://gerrit.asterisk.org/7430
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Id190428bf1d931f2dbfd4b293f53ff8f20d98efa
Gerrit-Change-Number: 7430
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Mon, 04 Dec 2017 17:19:51 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171204/882d3665/attachment.html>