[Asterisk-code-review] chan pjsip: Add tag info in CHANNEL function (asterisk[13])

Joshua Colp asteriskteam at digium.com
Mon Aug 28 05:03:14 CDT 2017


Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/6316 )

Change subject: chan_pjsip: Add tag info in CHANNEL function
......................................................................


Patch Set 1: Code-Review-1

The test at https://github.com/asterisk/testsuite/tree/master/tests/channels/pjsip/dialplan_functions/pjsip_channel needs to be updated to also test for this. Since one of the values is generated by PJSIP that can't be tested, but the one provided by SIPp is partially static (contains SIPpTag00) so it should be possible to confirm it is in there.


-- 
To view, visit https://gerrit.asterisk.org/6316
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I59b16c4b928896fcbde02ad88f0e98922b15d524
Gerrit-Change-Number: 6316
Gerrit-PatchSet: 1
Gerrit-Owner: Andre Nazario <samoied at users.sourceforge.net>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Mon, 28 Aug 2017 10:03:14 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170828/cc140933/attachment.html>


More information about the asterisk-code-review mailing list