[Asterisk-code-review] main/app: Only look to end of file if ':end' is specified, a... (asterisk[13])

Sean Bright asteriskteam at digium.com
Thu Aug 24 13:37:36 CDT 2017


Sean Bright has uploaded a new patch set (#2). ( https://gerrit.asterisk.org/6300 )

Change subject: main/app: Only look to end of file if ':end' is specified, and not just ':'
......................................................................

main/app: Only look to end of file if ':end' is specified, and not just ':'

There is a little known feature in app_controlplayback that will cause the
specified offset to be used relative to the end of a file if a ':end' is
detected within the filename.

This feature is pretty bad, but okay.

However, a bug exists in this code where a ':' detected in the filename
will cause the end pointer to be non-NULL, even if the full ':end' isn't
specified. This causes us to treat an unspecified offset (0) as being
"start playing from the end of the file", resulting in no file playback
occurring.

This patch fixes this bug by resetting the end pointer if ':end' is not
found in the filename.

ASTERISK-23608 #close

Change-Id: Ib4c7b1b45283e4effd622a970055c51146892f35
(cherry picked from commit 13efea24f7ce6ccc01d1a5a0603be2636d83a408)
---
M main/app.c
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/00/6300/2
-- 
To view, visit https://gerrit.asterisk.org/6300
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib4c7b1b45283e4effd622a970055c51146892f35
Gerrit-Change-Number: 6300
Gerrit-PatchSet: 2
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170824/790078b2/attachment.html>


More information about the asterisk-code-review mailing list