[Asterisk-code-review] chan pjsip.c: Fix topology refresh response code accuracy. (asterisk[15])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/6269 )

Change subject: chan_pjsip.c: Fix topology refresh response code accuracy.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/6269/1/channels/chan_pjsip.c
File channels/chan_pjsip.c:

https://gerrit.asterisk.org/#/c/6269/1/channels/chan_pjsip.c@1494
PS1, Line 1494: 	} else if (300 <= rdata->msg_info.msg->line.status.code) {
> I would prefer the literal operand be on the right side of the expression, 
It's more of a personal preference either way.  I prefer it this way so it is a little more visual (as on a number line).

It's easier to see that x is desired to be within a range here:
if (100 < x && x < 200)

And you can see that x needs to be outside the range here:
if (x < 100 && 200 < x)



-- 
To view, visit https://gerrit.asterisk.org/6269
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: comment
Gerrit-Change-Id: I680db0997343256add1478714f5bf5b5569aee17
Gerrit-Change-Number: 6269
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Tue, 22 Aug 2017 18:13:41 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170822/f52f41ea/attachment-0001.html>