[Asterisk-code-review] res xmpp: fix inverted return code check in OAuth (asterisk[13])

Michael Kuron asteriskteam at digium.com
Tue Aug 22 00:35:07 CDT 2017


Hello Jenkins2, Andrey, Sean Bright, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/6249

to look at the new patch set (#2).

Change subject: res_xmpp: fix inverted return code check in OAuth
......................................................................

res_xmpp: fix inverted return code check in OAuth

fetch_access_token calls func_curl via ast_func_read. The latter returns 0 upon
success and -1 if the function is not available.
This commit inverts the return code check so that an error is printed if the
module is not loaded and not if it is loaded.

ASTERISK-27207 #close

Change-Id: I9ef903f80702d1218e8701f65a4e5e918e6548fb
---
M res/res_xmpp.c
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/49/6249/2
-- 
To view, visit https://gerrit.asterisk.org/6249
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9ef903f80702d1218e8701f65a4e5e918e6548fb
Gerrit-Change-Number: 6249
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Kuron <m.kuron at gmx.de>
Gerrit-Reviewer: Andrey <andr06 at gmail.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Michael Kuron <m.kuron at gmx.de>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170822/3b5d7218/attachment.html>


More information about the asterisk-code-review mailing list