[Asterisk-code-review] res xmpp: fix inverted return code check (asterisk[13])

[Michael Kuron]

Michael Kuron has uploaded this change for review. ( https://gerrit.asterisk.org/6249


Change subject: res_xmpp: fix inverted return code check
......................................................................

res_xmpp: fix inverted return code check

fetch_access_token calls func_curl via ast_func_read. The latter returns 0 upon
success and -1 if the function is not available.
This commit inverts the return code check so that an error is printed if the
module is not loaded and not if it is loaded.

ASTERISK-27207 #close

Change-Id: I9ef903f80702d1218e8701f65a4e5e918e6548fb
---
M res/res_xmpp.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/49/6249/1

diff --git a/res/res_xmpp.c b/res/res_xmpp.c
index bff59b8..cd192da 100644
--- a/res/res_xmpp.c
+++ b/res/res_xmpp.c
@@ -3917,7 +3917,7 @@
 	ast_debug(2, "Performing OAuth 2.0 authentication for client '%s' using command: %s\n",
 		cfg->name, cmd);
 
-	if (!ast_func_read(NULL, cmd, cBuf, sizeof(cBuf) - 1)) {
+	if (ast_func_read(NULL, cmd, cBuf, sizeof(cBuf) - 1) != 0) {
 		ast_log(LOG_ERROR, "CURL is unavailable. This is required for OAuth 2.0 authentication of XMPP client '%s'. Please ensure it is loaded.\n",
 			cfg->name);
 		return -1;

-- 
To view, visit https://gerrit.asterisk.org/6249
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9ef903f80702d1218e8701f65a4e5e918e6548fb
Gerrit-Change-Number: 6249
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Kuron <m.kuron at gmx.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170820/8c84692c/attachment.html>