[Asterisk-code-review] Make --with-pjproject-bundled the default for Asterisk 15 (asterisk[master])

Corey Farrell asteriskteam at digium.com
Tue Aug 8 14:18:32 CDT 2017


Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/6175 )

Change subject: Make --with-pjproject-bundled the default for Asterisk 15
......................................................................


Patch Set 1:

> > (1 comment)
 > 
 > All of the other options are documented as "--with" do changing to
 > "--without" seemed wrong somehow.  I could change it to a feature
 > enable/disable but that's not how it is in 13 and 14.  What do you
 > think?

Hmmm.. realistically enable/disable probably would have been better since '--with' options normally accept a parameter (--with-libxml2=PATH).  That said --with-pjproject-bundled is already in place.  I don't know.  I do think it's probably important that './configure --help' indicate that pjproject-bundled is enabled by default.


-- 
To view, visit https://gerrit.asterisk.org/6175
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa9783fddf44aafadb060c9feba713dfa81d38ce
Gerrit-Change-Number: 6175
Gerrit-PatchSet: 1
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Comment-Date: Tue, 08 Aug 2017 19:18:32 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170808/0fc2ddc9/attachment.html>


More information about the asterisk-code-review mailing list