[Asterisk-code-review] pbx dundi: Added IPv6 support for dundi (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/6173 )

Change subject: pbx_dundi: Added IPv6 support for dundi
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

This implementation appears to reimplement a lot of what netsock2 has been created to do, and as a result has complicated and duplicated code in a lot of places. I think a good path to having this included would be using netsock2 underneath instead. This would simplify the changes and also ensure that common code is used.

https://gerrit.asterisk.org/#/c/6173/1/pbx/dundi-parser.c
File pbx/dundi-parser.c:

https://gerrit.asterisk.org/#/c/6173/1/pbx/dundi-parser.c@603
PS1, Line 603: #ifdef IPV6
             : 	return dundi_ie_append_raw(ied, ie, &sin->i6, (int)sizeof(sin->i6));
             : #else
             : 	return dundi_ie_append_raw(ied, ie, &sin->i4, (int)sizeof(sin->i4));
             : #endif
Is it possible for an IPv4 host to receive an IPv6 address? If so for older versions what occurs?


https://gerrit.asterisk.org/#/c/6173/1/pbx/pbx_dundi.c
File pbx/pbx_dundi.c:

https://gerrit.asterisk.org/#/c/6173/1/pbx/pbx_dundi.c@4693
PS1, Line 4693: // TODO : check address population
I don't think this works with IPv6 due to the scanning for : which is present in IPv6 addresses.



-- 
To view, visit https://gerrit.asterisk.org/6173
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbe298afc6416ba400db7be404a25994ad23968a
Gerrit-Change-Number: 6173
Gerrit-PatchSet: 1
Gerrit-Owner: Adam Secombe <adam.j.secombe at boeing.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Mon, 07 Aug 2017 13:41:59 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170807/79aa4927/attachment.html>