[Asterisk-code-review] res rtp asterisk: Make P2P bridge Asymmetric codec aware (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/6117 )

Change subject: res_rtp_asterisk:  Make P2P bridge Asymmetric codec aware
......................................................................


Patch Set 4: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/6117/4/res/res_rtp_asterisk.c
File res/res_rtp_asterisk.c:

https://gerrit.asterisk.org/#/c/6117/4/res/res_rtp_asterisk.c@4891
PS4, Line 4891: 	if (!bridged->asymmetric_codec && bridged->lastrxformat != ast_format_none) {
              : 		if (ast_format_cmp(bridged->lasttxformat, bridged->lastrxformat) == AST_FORMAT_CMP_NOT_EQUAL) {
              : 			ast_debug(1, "Asymmetric RTP codecs detected (TX: %s, RX: %s) sending frame to core\n",
              : 					ast_format_get_name(bridged->lasttxformat),
              : 					ast_format_get_name(bridged->lastrxformat));
              : 			return -1;
              : 		}
              : 	}
Why hide this behind an explicit option? There should be no harm in passing this through the core explicitly if the format changes. If the technology can remain the same, it will.



-- 
To view, visit https://gerrit.asterisk.org/6117
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I0d9c83e5356df81661e58d40a8db565833501a6f
Gerrit-Change-Number: 6117
Gerrit-PatchSet: 4
Gerrit-Owner: Torrey Searle <tsearle at gmail.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Mon, 07 Aug 2017 11:04:52 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170807/e0999045/attachment.html>