[Asterisk-code-review] alembic/res pjsip: Add "webrtc" configuration option (asterisk[15])

Kevin Harwell asteriskteam at digium.com
Thu Aug 3 11:05:42 CDT 2017


Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/6126 )

Change subject: alembic/res_pjsip: Add "webrtc" configuration option
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/6126/1/contrib/ast-db-manage/config/versions/44ccced114ce_add_webrtc_enabled.py
File contrib/ast-db-manage/config/versions/44ccced114ce_add_webrtc_enabled.py:

https://gerrit.asterisk.org/#/c/6126/1/contrib/ast-db-manage/config/versions/44ccced114ce_add_webrtc_enabled.py@27
PS1, Line 27:     op.add_column('ps_endpoints', sa.Column('webrtc_enabled', yesno_values))
> Shouldn't these be "webrtc" not "webrtc_enabled"?
yes good catch! I had renamed it and forgot to do it here.



-- 
To view, visit https://gerrit.asterisk.org/6126
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: comment
Gerrit-Change-Id: I3e199f060aea25e193c439fc5cf96be4d3ed1c7b
Gerrit-Change-Number: 6126
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Thu, 03 Aug 2017 16:05:42 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170803/1aa69e3e/attachment.html>


More information about the asterisk-code-review mailing list