[Asterisk-code-review] chan sip: Add dialplan function SIP HEADERS (asterisk[master])

Richard Mudgett rmudgett at digium.com
Wed Aug 2 19:04:03 CDT 2017


On Wed, Aug 2, 2017 at 6:19 PM, Kirill Katsnelson <kkm at smartaction.com>
wrote:

> Sean, thanks for the fix.  I do not understand what was wrong with the
> scoped lock. I am a big fan of scoped constructs in general, they are
> more defensive IMO.  Just so I learn, why it should not have been used?
> Was the issue a variable declaration after imperative code, which is
> nonstandard C? Is this why Jenkins was reporting a failure? I have no
> access to its logs from here.
>

Yes.  You are correct.  It was because the scoped lock was declared after
normal code statements.

Richard
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170802/6b8d041e/attachment.html>


More information about the asterisk-code-review mailing list