[Asterisk-code-review] SDP API: Add SSRC-level attributes (asterisk[master])

Richard Mudgett asteriskteam at digium.com
Thu Apr 27 15:55:50 CDT 2017


Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/5550 )

Change subject: SDP API: Add SSRC-level attributes
......................................................................


Patch Set 3: Code-Review+1

(2 comments)

https://gerrit.asterisk.org/#/c/5550/3/main/rtp_engine.c
File main/rtp_engine.c:

Line 3350: 		ssrc = rtp->engine->ssrc_get(rtp);
I'll +1 this even though we only need to lock around this call.


Line 3363: 		cname = rtp->engine->cname_get(rtp);
I'll +1 this even though we only need to lock around this call.


-- 
To view, visit https://gerrit.asterisk.org/5550
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29e7f23e7db77524f82a3b6e8531b1195ff57789
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list