[Asterisk-code-review] SDP API: Add SSRC-level attributes (asterisk[master])

[Mark Michelson]

Mark Michelson has posted comments on this change. ( https://gerrit.asterisk.org/5550 )

Change subject: SDP API: Add SSRC-level attributes
......................................................................


Patch Set 2:

(4 comments)

https://gerrit.asterisk.org/#/c/5550/2/main/rtp_engine.c
File main/rtp_engine.c:

Line 3352: 		return rtp->engine->cname_get(rtp);
> same here.
No, the CNAME is supposed to be a consistent identifier of a specific user, so even if other identifiers change (like SSRC), the CNAME will remain constant.


https://gerrit.asterisk.org/#/c/5550/2/main/sdp_private.h
File main/sdp_private.h:

Line 46: 		unsigned int ssrc: 1;
> should be
I'm just copying the style used within the file. If this is a problem, then the entire file should be changed in a separate style-update commit.


https://gerrit.asterisk.org/#/c/5550/2/main/sdp_state.c
File main/sdp_state.c:

Line 1196: static void add_ssrc_attributes(struct ast_sdp_m_line *m_line, const struct ast_sdp_options *options,
> Should this return an error if we fail to create the a_line?
No, failing to add SSRC level attributes is something we really don't care that much about.


Line 1343: 	add_ssrc_attributes(m_line, options, rtp);
> Should we fail the SDP m line creation if we couldn't add the ssrc attribut
Nope. We'll just send without the SSRC attribute(s)


-- 
To view, visit https://gerrit.asterisk.org/5550
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I29e7f23e7db77524f82a3b6e8531b1195ff57789
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes