[Asterisk-code-review] core: Use eventfd for alert pipes on Linux when possible (asterisk[14])

[Sean Bright]

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/5498 )

Change subject: core: Use eventfd for alert pipes on Linux when possible
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.asterisk.org/#/c/5498/2/main/alertpipe.c
File main/alertpipe.c:

PS2, Line 76: 	if (alert_pipe[0] > -1) {
            : 		close(alert_pipe[0]);
            : 		alert_pipe[0] = -1;
            : 	}
            : 	if (alert_pipe[1] > -1) {
            : 		close(alert_pipe[1]);
            : 		alert_pipe[1] = -1;
            : 	}
> This would close the same eventfd twice. Is that acceptable?
> This would close the same eventfd twice. Is that acceptable?

The second close() would just fail with EBADF. I'll fix.


-- 
To view, visit https://gerrit.asterisk.org/5498
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iff0fb1573e7f7a187d5211ddc60aa8f3da3edb1d
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 14
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-HasComments: Yes