[Asterisk-code-review] Revert "bridging: Ensure successful T.38 negotation" (asterisk[14])

[Richard Mudgett]

Hello George Joseph, Torrey Searle, Anonymous Coward #1000019, Joshua Colp,

I'd like you to do a code review.  Please visit

    https://gerrit.asterisk.org/5491

to review the following change.


Change subject: Revert "bridging:  Ensure successful T.38 negotation"
......................................................................

Revert "bridging:  Ensure successful T.38 negotation"

This reverts commit 443058f154923b565bafb30e20e9ec35f253a84b.

Change-Id: Ifae215f971d2b235a2c2d61dd74c5dd8abad57ba
---
M bridges/bridge_simple.c
1 file changed, 0 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/91/5491/1

diff --git a/bridges/bridge_simple.c b/bridges/bridge_simple.c
index 22089aa..fc12bd1 100644
--- a/bridges/bridge_simple.c
+++ b/bridges/bridge_simple.c
@@ -58,19 +58,6 @@
 		return 0;
 	}
 
-	/* Request resend of T.38 negotiation if in progress and the other leg not yet T.38
-	 */
-	if (ast_channel_get_t38_state(c0) == T38_STATE_NEGOTIATING && ast_channel_get_t38_state(c1) == T38_STATE_UNKNOWN) {
-		struct ast_control_t38_parameters parameters = { .request_response = AST_T38_REQUEST_PARMS, };
-		ast_debug(3, "Sending T.38 param renegotiation to first channel %s.\n", ast_channel_name(c0));
-		ast_indicate_data(c0, AST_CONTROL_T38_PARAMETERS, &parameters, sizeof(parameters));
-	}
-	if (ast_channel_get_t38_state(c1) == T38_STATE_NEGOTIATING && ast_channel_get_t38_state(c0) == T38_STATE_UNKNOWN) {
-		struct ast_control_t38_parameters parameters = { .request_response = AST_T38_REQUEST_PARMS, };
-		ast_debug(3, "Sending T.38 param renegotiation to second channel %s.\n", ast_channel_name(c1));
-		ast_indicate_data(c1, AST_CONTROL_T38_PARAMETERS, &parameters, sizeof(parameters));
-	}
-
 	return ast_channel_make_compatible(c0, c1);
 }
 

-- 
To view, visit https://gerrit.asterisk.org/5491
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifae215f971d2b235a2c2d61dd74c5dd8abad57ba
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 14
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Torrey Searle <tsearle at gmail.com>