[Asterisk-code-review] modules: change module LOAD FAILUREs to LOAD DECLINES (14) (asterisk[14])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/5456 )

Change subject: modules:  change module LOAD_FAILUREs to LOAD_DECLINES (14)
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/5456/1/res/res_http_media_cache.c
File res/res_http_media_cache.c:

PS1, Line 427: 	if (ast_bucket_scheme_register("http", &http_bucket_wizard, &http_bucket_file_wizard,
             : 			NULL, NULL)) {
             : 		ast_log(LOG_ERROR, "Failed to register Bucket HTTP wizard scheme implementation\n");
             : 		return AST_MODULE_LOAD_DECLINE;
             : 	}
             : 
             : 	if (ast_bucket_scheme_register("https", &https_bucket_wizard, &https_bucket_file_wizard,
             : 			NULL, NULL)) {
             : 		ast_log(LOG_ERROR, "Failed to register Bucket HTTPS wizard scheme implementation\n");
             : 		return AST_MODULE_LOAD_DECLINE;
             : 	}
Hmm.  There is no scheme unregister to undo a successful register.  You thus cannot ever reload successfully if the first scheme got registered.  Probably have to keep this module returning LOAD_FAILURE or never decline.


-- 
To view, visit https://gerrit.asterisk.org/5456
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If99e3b4fc2d7e86fc3e61182aa6c835b407ed49e
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 14
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes