[Asterisk-code-review] modules: change module LOAD FAILUREs to LOAD DECLINES (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/5450 )

Change subject: modules:  change module LOAD_FAILUREs to LOAD_DECLINES
......................................................................


Patch Set 2: Code-Review-1

(3 comments)

https://gerrit.asterisk.org/#/c/5450/2/addons/cdr_mysql.c
File addons/cdr_mysql.c:

Line 680: 		return AST_MODULE_LOAD_DECLINE;
Should this free strings and columns too?


https://gerrit.asterisk.org/#/c/5450/2/channels/chan_iax2.c
File channels/chan_iax2.c:

Line 15102: 		ao2_ref(iax2_tech.capabilities, -1);
This should NULL out iax2_tech.capabilities here too.


https://gerrit.asterisk.org/#/c/5450/2/channels/chan_nbs.c
File channels/chan_nbs.c:

Line 268: 		return AST_MODULE_LOAD_DECLINE;
You're here so might as well fix this memory leak with capabilities.


-- 
To view, visit https://gerrit.asterisk.org/5450
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5f4b50623d9b5a6cb7c5624a8c5c1274c13b2b25
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes