[Asterisk-code-review] modules: change module LOAD FAILUREs to LOAD DECLINES (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/5450 )

Change subject: modules:  change module LOAD_FAILUREs to LOAD_DECLINES
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

I don't think it is as simple as replacing LOAD_FAILURE with LOAD_DECLINE.  Many modules may not have cleaned up after themselves when they returned LOAD_FAILURE.

I only looked at the addons/cdr_mysql.c.

https://gerrit.asterisk.org/#/c/5450/1/addons/cdr_mysql.c
File addons/cdr_mysql.c:

Line 521: 		return AST_MODULE_LOAD_DECLINE;
You'll need to do a my_unload_module() here to clean up any allocated resources on failure.  BEWARE that there is likely a locking issue because this module relied on FAILURE to clean up after itself.

This is the same for the other FAILURE -> DECLINE changes in this module.


-- 
To view, visit https://gerrit.asterisk.org/5450
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5f4b50623d9b5a6cb7c5624a8c5c1274c13b2b25
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes