[Asterisk-code-review] processpending: Clean it up. (repotools[master])

Joshua Colp asteriskteam at digium.com
Mon Apr 10 05:12:27 CDT 2017


Joshua Colp has submitted this change and it was merged. ( https://gerrit.asterisk.org/5424 )

Change subject: processpending:  Clean it up.
......................................................................


processpending:  Clean it up.

Removed the bogus "you must do manually" notice.
Removed the "Press a key to continue" message.
Added a prompt to commit.

Change-Id: Icb52592e49a46b2c4b06c9e8a845cbb53500dfc3
---
M processpending
1 file changed, 7 insertions(+), 11 deletions(-)

Approvals:
  Kevin Harwell: Looks good to me, but someone else must approve
  Joshua Colp: Looks good to me, approved; Verified



diff --git a/processpending b/processpending
index 3b4e57d..c188a49 100755
--- a/processpending
+++ b/processpending
@@ -5,18 +5,7 @@
 This script moves releases from the pending directory into the public releases
 directory.  It also creates the symlinks for each file in the base directory.
 
-There are a couple of things that this script does not do for you, that you
-must do manually before or after running this script.
-  1) Remove the symlinks for the previous release.
-  2) Create a new "current" link, such as asterisk-1.4-current.tar.gz
-     Note: this can't be done in one commit for some reason.  Remove it one
-	 commit, re-create it and commit it in another commit.
-
-Press a key to continue.
-
 EOF
-
-read
 
 svn up
 for n in `ls pending` ; do
@@ -24,3 +13,10 @@
 	ln -s releases/$n $n
 	svn add $n
 done
+
+read -p "Commit? y/N" answer
+if [ ${answer,,} = "y" ] ; then
+	svn commit -m "Move releases out of pending"
+else
+	echo "Aborted.  Commit manually when ready."
+fi

-- 
To view, visit https://gerrit.asterisk.org/5424
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icb52592e49a46b2c4b06c9e8a845cbb53500dfc3
Gerrit-PatchSet: 1
Gerrit-Project: repotools
Gerrit-Branch: master
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>



More information about the asterisk-code-review mailing list