[Asterisk-code-review] app queue: Log reason for PAUSEALL/UNPAUSEALL (asterisk[master])

[Anonymous Coward]

Anonymous Coward #1000019 has submitted this change and it was merged. ( https://gerrit.asterisk.org/5399 )

Change subject: app_queue: Log reason for PAUSEALL/UNPAUSEALL
......................................................................


app_queue: Log reason for PAUSEALL/UNPAUSEALL

We needed the reason for our reporting when agents pause/unpause all of
their queues at once.  This is a small, simple patch that adds a reason
for PAUSEALL and UNPAUSEALL.  I have been using it in production for years.

ASTERISK-26920 #close

Change-Id: Ifb3f0d1a0abd5194253d9794023546e1395baf3d
---
M CHANGES
M apps/app_queue.c
2 files changed, 6 insertions(+), 1 deletion(-)

Approvals:
  Richard Mudgett: Looks good to me, but someone else must approve
  Anonymous Coward #1000019: Verified
  Joshua Colp: Looks good to me, approved



diff --git a/CHANGES b/CHANGES
index f7f8505..9a82e1f 100644
--- a/CHANGES
+++ b/CHANGES
@@ -12,6 +12,11 @@
 --- Functionality changes from Asterisk 14 to Asterisk 15 --------------------
 ------------------------------------------------------------------------------
 
+app_queue
+------------------
+ * PAUSEALL/UNPAUSEALL now sets the pause reason in the queue_log if it has
+   been defined.
+
 ------------------------------------------------------------------------------
 --- Functionality changes from Asterisk 14.4.0 to Asterisk 14.5.0 ------------
 ------------------------------------------------------------------------------
diff --git a/apps/app_queue.c b/apps/app_queue.c
index 9bba676..ae2d645 100644
--- a/apps/app_queue.c
+++ b/apps/app_queue.c
@@ -7332,7 +7332,7 @@
 					 * but since this affects all queues, we cannot.
 					 */
 					ast_queue_log("NONE", "NONE", mem->membername,
-						(paused ? "PAUSEALL" : "UNPAUSEALL"), "%s", "");
+						(paused ? "PAUSEALL" : "UNPAUSEALL"), "%s", S_OR(reason, ""));
 				}
 
 				set_queue_member_pause(q, mem, reason, paused);

-- 
To view, visit https://gerrit.asterisk.org/5399
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifb3f0d1a0abd5194253d9794023546e1395baf3d
Gerrit-PatchSet: 6
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Troy Bowman <troy at lump.net>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Troy Bowman <troy at lump.net>