[Asterisk-code-review] astobj2: Add backtrace to log bad ao2. (asterisk[master])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: astobj2: Add backtrace to log_bad_ao2.
......................................................................


Patch Set 1: Code-Review-1

(6 comments)

Minor stuff

https://gerrit.asterisk.org/#/c/3927/1/main/astobj2_container.c
File main/astobj2_container.c:

PS1, Line 453: 
             : 
             : 
             : 
             : 
You should keep this check and remove the other redundant check below.


Line 110: 		__ast_assert_failed(0, "self->v_table", file, line, func);
Should change the assert message since the assert is going to reference the caller's location.
"invalid container v_table."


Line 253: 		__ast_assert_failed(0, "self->v_table", file, line, func);
Should change the assert message since the assert is going to reference the caller's location.
"invalid container v_table."


Line 529: 		__ast_assert_failed(0, "iter->c->v_table", file, line, func);
Should change the assert message since the assert is going to reference the caller's location.
"invalid iterator container v_table."


Line 672: 		__ast_assert_failed(0, "self->v_table", file, line, func);
Should change the assert message since the assert is going to reference the caller's location.
"invalid container v_table."


https://gerrit.asterisk.org/#/c/3927/1/main/utils.c
File main/utils.c:

PS1, Line 2441: 	fprintf(stderr, "FRACK!, Failed assertion %s (%d) at line %d in %s of %s\n",
              : 		condition_str, condition, line, function, file);
              : 	ast_log(__LOG_ERROR, file, line, function, "FRACK!, Failed assertion %s (%d)\n",
              : 		condition_str, condition);
Why did you need to swap these statements?


-- 
To view, visit https://gerrit.asterisk.org/3927
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I48f1af44b2718ad74a421ff75cb6397b924a9751
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes