[Asterisk-code-review] chan sip: Address runaway when realtime peers subscribe to ... (asterisk[master])

[George Joseph]

George Joseph has posted comments on this change.

Change subject: chan_sip:  Address runaway when realtime peers subscribe to mailboxes
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.asterisk.org/#/c/3965/2/channels/chan_sip.c
File channels/chan_sip.c:

Line 17283: 	if (stasis_subscription_final_message(sub, msg) || peer_in_destruction(peer)) {
> This is the only part of this change that I question. If it is possible for
Corey, Josh and I went around on this and we don't think so.  The peer CAN'T go away while this message is being processed because the first thing the destructor does is unsubscribe_and_join and waits for the last message to complete.  That doesn't get set until after the last message has been processed.


-- 
To view, visit https://gerrit.asterisk.org/3965
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I07519ef7f092629e1e844f855abd279d6475cdd0
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: Yes