[Asterisk-code-review] res pjsip session: Send request even if the state is disconn... (asterisk[master])

[Alexei Gradinari]

Alexei Gradinari has posted comments on this change.

Change subject: res_pjsip_session: Send request even if the state is disconnected
......................................................................


Patch Set 2:

> Alexei,
 > Don't you think that the right solution is the patch in pjsip I
 > sent?
 > See http://lists.pjsip.org/pipermail/pjsip_lists.pjsip.org/2016-September/019541.html
 > 

I saw your patch.
I looked more deeply into the codes of pjsip and asterisk, because I don't agree with your patch.

I don't think this is the right way.
The pjsip disconnects the session only if the pjsip doesn't have a credentials.
The pjsip doesn't have the credentials because the asterisk doesn't provide the credentials.
The pjsip is used by many other applications.
The application has to provide the credentials or handle 401/407 responses.

-- 
To view, visit https://gerrit.asterisk.org/3886
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7254684dc07bc739c10597f3bec92f470eace137
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Yaacov Akiba Slama <yaslama at gmail.com>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Yaacov Akiba Slama <yaslama at gmail.com>
Gerrit-HasComments: No